Fix Kotlin fake source mapping#10880
Fix Kotlin fake source mapping#10880gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomasterfrom
Conversation
When there is no mapping to original source code, Kotlin SMAP use the fake.kt file inside the SoruceDebugExtenstion. Need to support this to avoid having line not correctly mapped and that are beyond the end of the file
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (326.424 µs) : 281, 372
. : milestone, 326,
basic (278.143 µs) : 271, 285
. : milestone, 278,
loop (8.96 ms) : 8956, 8964
. : milestone, 8960,
section candidate
noprobe (311.841 µs) : 285, 338
. : milestone, 312,
basic (277.378 µs) : 271, 284
. : milestone, 277,
loop (8.958 ms) : 8953, 8962
. : milestone, 8958,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~56fb595247, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058639
Total [baseline] (11.031 s) : 0, 11030926
Agent [candidate] (1.061 s) : 0, 1061379
Total [candidate] (11.021 s) : 0, 11021120
section appsec
Agent [baseline] (1.248 s) : 0, 1248292
Total [baseline] (11.18 s) : 0, 11180160
Agent [candidate] (1.254 s) : 0, 1253609
Total [candidate] (11.268 s) : 0, 11267793
section iast
Agent [baseline] (1.228 s) : 0, 1228325
Total [baseline] (11.263 s) : 0, 11262539
Agent [candidate] (1.238 s) : 0, 1237555
Total [candidate] (11.268 s) : 0, 11268274
section profiling
Agent [baseline] (1.183 s) : 0, 1182830
Total [baseline] (11.012 s) : 0, 11011796
Agent [candidate] (1.182 s) : 0, 1182454
Total [candidate] (11.048 s) : 0, 11047968
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~56fb595247, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (627.594 ms) : 0, 627594
BytebuddyAgent [candidate] (629.062 ms) : 0, 629062
AgentMeter [baseline] (29.125 ms) : 0, 29125
AgentMeter [candidate] (29.154 ms) : 0, 29154
GlobalTracer [baseline] (256.768 ms) : 0, 256768
GlobalTracer [candidate] (257.169 ms) : 0, 257169
AppSec [baseline] (31.69 ms) : 0, 31690
AppSec [candidate] (31.699 ms) : 0, 31699
Debugger [baseline] (60.252 ms) : 0, 60252
Debugger [candidate] (60.248 ms) : 0, 60248
Remote Config [baseline] (609.676 µs) : 0, 610
Remote Config [candidate] (610.848 µs) : 0, 611
Telemetry [baseline] (8.046 ms) : 0, 8046
Telemetry [candidate] (8.108 ms) : 0, 8108
Flare Poller [baseline] (7.343 ms) : 0, 7343
Flare Poller [candidate] (7.931 ms) : 0, 7931
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (658.856 ms) : 0, 658856
BytebuddyAgent [candidate] (662.544 ms) : 0, 662544
AgentMeter [baseline] (12.06 ms) : 0, 12060
AgentMeter [candidate] (12.131 ms) : 0, 12131
GlobalTracer [baseline] (258.423 ms) : 0, 258423
GlobalTracer [candidate] (259.212 ms) : 0, 259212
AppSec [baseline] (178.173 ms) : 0, 178173
AppSec [candidate] (178.392 ms) : 0, 178392
Debugger [baseline] (66.331 ms) : 0, 66331
Debugger [candidate] (66.656 ms) : 0, 66656
Remote Config [baseline] (627.539 µs) : 0, 628
Remote Config [candidate] (622.62 µs) : 0, 623
Telemetry [baseline] (8.362 ms) : 0, 8362
Telemetry [candidate] (8.31 ms) : 0, 8310
Flare Poller [baseline] (3.595 ms) : 0, 3595
Flare Poller [candidate] (3.644 ms) : 0, 3644
IAST [baseline] (24.195 ms) : 0, 24195
IAST [candidate] (24.349 ms) : 0, 24349
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (796.104 ms) : 0, 796104
BytebuddyAgent [candidate] (802.209 ms) : 0, 802209
AgentMeter [baseline] (11.324 ms) : 0, 11324
AgentMeter [candidate] (11.62 ms) : 0, 11620
GlobalTracer [baseline] (247.728 ms) : 0, 247728
GlobalTracer [candidate] (248.934 ms) : 0, 248934
AppSec [baseline] (26.526 ms) : 0, 26526
AppSec [candidate] (26.841 ms) : 0, 26841
Debugger [baseline] (71.025 ms) : 0, 71025
Debugger [candidate] (71.704 ms) : 0, 71704
Remote Config [baseline] (539.118 µs) : 0, 539
Remote Config [candidate] (529.994 µs) : 0, 530
Telemetry [baseline] (9.09 ms) : 0, 9090
Telemetry [candidate] (9.27 ms) : 0, 9270
Flare Poller [baseline] (3.318 ms) : 0, 3318
Flare Poller [candidate] (3.36 ms) : 0, 3360
IAST [baseline] (25.345 ms) : 0, 25345
IAST [candidate] (25.548 ms) : 0, 25548
section profiling
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (682.721 ms) : 0, 682721
BytebuddyAgent [candidate] (683.388 ms) : 0, 683388
AgentMeter [baseline] (8.699 ms) : 0, 8699
AgentMeter [candidate] (8.625 ms) : 0, 8625
GlobalTracer [baseline] (215.622 ms) : 0, 215622
GlobalTracer [candidate] (215.016 ms) : 0, 215016
AppSec [baseline] (32.177 ms) : 0, 32177
AppSec [candidate] (32.367 ms) : 0, 32367
Debugger [baseline] (64.504 ms) : 0, 64504
Debugger [candidate] (65.288 ms) : 0, 65288
Remote Config [baseline] (577.204 µs) : 0, 577
Remote Config [candidate] (570.473 µs) : 0, 570
Telemetry [baseline] (9.225 ms) : 0, 9225
Telemetry [candidate] (8.396 ms) : 0, 8396
Flare Poller [baseline] (3.453 ms) : 0, 3453
Flare Poller [candidate] (3.474 ms) : 0, 3474
ProfilingAgent [baseline] (93.791 ms) : 0, 93791
ProfilingAgent [candidate] (93.418 ms) : 0, 93418
Profiling [baseline] (94.352 ms) : 0, 94352
Profiling [candidate] (93.973 ms) : 0, 93973
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~56fb595247, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064345
Total [baseline] (8.853 s) : 0, 8852585
Agent [candidate] (1.058 s) : 0, 1057905
Total [candidate] (8.844 s) : 0, 8843891
section iast
Agent [baseline] (1.235 s) : 0, 1235418
Total [baseline] (9.554 s) : 0, 9553543
Agent [candidate] (1.226 s) : 0, 1226140
Total [candidate] (9.584 s) : 0, 9584160
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~56fb595247, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (630.634 ms) : 0, 630634
BytebuddyAgent [candidate] (627.844 ms) : 0, 627844
AgentMeter [baseline] (29.342 ms) : 0, 29342
AgentMeter [candidate] (29.014 ms) : 0, 29014
GlobalTracer [baseline] (257.456 ms) : 0, 257456
GlobalTracer [candidate] (257.503 ms) : 0, 257503
AppSec [baseline] (31.909 ms) : 0, 31909
AppSec [candidate] (31.75 ms) : 0, 31750
Debugger [baseline] (59.73 ms) : 0, 59730
Debugger [candidate] (59.404 ms) : 0, 59404
Remote Config [baseline] (607.91 µs) : 0, 608
Remote Config [candidate] (590.992 µs) : 0, 591
Telemetry [baseline] (8.181 ms) : 0, 8181
Telemetry [candidate] (8.009 ms) : 0, 8009
Flare Poller [baseline] (9.01 ms) : 0, 9010
Flare Poller [candidate] (6.513 ms) : 0, 6513
section iast
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (802.688 ms) : 0, 802688
BytebuddyAgent [candidate] (795.574 ms) : 0, 795574
AgentMeter [baseline] (11.526 ms) : 0, 11526
AgentMeter [candidate] (11.339 ms) : 0, 11339
GlobalTracer [baseline] (248.171 ms) : 0, 248171
GlobalTracer [candidate] (247.257 ms) : 0, 247257
AppSec [baseline] (26.755 ms) : 0, 26755
AppSec [candidate] (26.412 ms) : 0, 26412
Debugger [baseline] (69.433 ms) : 0, 69433
Debugger [candidate] (69.117 ms) : 0, 69117
Remote Config [baseline] (526.841 µs) : 0, 527
Remote Config [candidate] (527.176 µs) : 0, 527
Telemetry [baseline] (9.695 ms) : 0, 9695
Telemetry [candidate] (9.777 ms) : 0, 9777
Flare Poller [baseline] (3.487 ms) : 0, 3487
Flare Poller [candidate] (3.515 ms) : 0, 3515
IAST [baseline] (25.54 ms) : 0, 25540
IAST [candidate] (25.255 ms) : 0, 25255
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~56fb595247, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section baseline
no_agent (17.99 ms) : 17806, 18173
. : milestone, 17990,
appsec (18.561 ms) : 18373, 18748
. : milestone, 18561,
code_origins (17.89 ms) : 17711, 18068
. : milestone, 17890,
iast (17.543 ms) : 17368, 17719
. : milestone, 17543,
profiling (19.865 ms) : 19665, 20064
. : milestone, 19865,
tracing (17.424 ms) : 17249, 17598
. : milestone, 17424,
section candidate
no_agent (18.949 ms) : 18753, 19145
. : milestone, 18949,
appsec (18.547 ms) : 18357, 18737
. : milestone, 18547,
code_origins (18.097 ms) : 17914, 18279
. : milestone, 18097,
iast (17.597 ms) : 17423, 17772
. : milestone, 17597,
profiling (19.058 ms) : 18869, 19246
. : milestone, 19058,
tracing (17.861 ms) : 17686, 18036
. : milestone, 17861,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~56fb595247, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section baseline
no_agent (1.242 ms) : 1229, 1256
. : milestone, 1242,
iast (3.219 ms) : 3176, 3261
. : milestone, 3219,
iast_FULL (5.756 ms) : 5698, 5813
. : milestone, 5756,
iast_GLOBAL (3.446 ms) : 3387, 3505
. : milestone, 3446,
profiling (1.992 ms) : 1975, 2008
. : milestone, 1992,
tracing (1.75 ms) : 1735, 1764
. : milestone, 1750,
section candidate
no_agent (1.177 ms) : 1165, 1188
. : milestone, 1177,
iast (3.285 ms) : 3238, 3332
. : milestone, 3285,
iast_FULL (6.036 ms) : 5975, 6097
. : milestone, 6036,
iast_GLOBAL (3.701 ms) : 3635, 3766
. : milestone, 3701,
profiling (2.163 ms) : 2143, 2183
. : milestone, 2163,
tracing (1.818 ms) : 1803, 1832
. : milestone, 1818,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~56fb595247, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.794 ms) : 3574, 4014
. : milestone, 3794,
iast (2.253 ms) : 2184, 2323
. : milestone, 2253,
iast_GLOBAL (2.308 ms) : 2238, 2378
. : milestone, 2308,
profiling (2.099 ms) : 2042, 2155
. : milestone, 2099,
tracing (2.069 ms) : 2015, 2123
. : milestone, 2069,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.726 ms) : 3511, 3941
. : milestone, 3726,
iast (2.258 ms) : 2189, 2328
. : milestone, 2258,
iast_GLOBAL (2.31 ms) : 2240, 2380
. : milestone, 2310,
profiling (2.117 ms) : 2060, 2175
. : milestone, 2117,
tracing (2.077 ms) : 2023, 2132
. : milestone, 2077,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~56fb595247, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section baseline
no_agent (15.327 s) : 15327000, 15327000
. : milestone, 15327000,
appsec (14.759 s) : 14759000, 14759000
. : milestone, 14759000,
iast (17.917 s) : 17917000, 17917000
. : milestone, 17917000,
iast_GLOBAL (17.874 s) : 17874000, 17874000
. : milestone, 17874000,
profiling (14.844 s) : 14844000, 14844000
. : milestone, 14844000,
tracing (14.858 s) : 14858000, 14858000
. : milestone, 14858000,
section candidate
no_agent (15.643 s) : 15643000, 15643000
. : milestone, 15643000,
appsec (14.371 s) : 14371000, 14371000
. : milestone, 14371000,
iast (18.132 s) : 18132000, 18132000
. : milestone, 18132000,
iast_GLOBAL (17.961 s) : 17961000, 17961000
. : milestone, 17961000,
profiling (15.426 s) : 15426000, 15426000
. : milestone, 15426000,
tracing (14.71 s) : 14710000, 14710000
. : milestone, 14710000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
When there is no mapping to original source code, Kotlin SMAP use the fake.kt file inside the SoruceDebugExtenstion. Need to support this to avoid having line not correctly mapped and that are beyond the end of the file
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-5328
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.